Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): skip ada compilation in amazon-linux-2 #13632

Closed
wants to merge 1 commit into from

Conversation

Water-Melon
Copy link
Contributor

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed build/bazel labels Sep 6, 2024
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 6, 2024
@Water-Melon Water-Melon force-pushed the skip_ada_in_aws_linux_2 branch 19 times, most recently from 50f552f to 8d03308 Compare September 6, 2024 18:26
@Water-Melon Water-Melon force-pushed the skip_ada_in_aws_linux_2 branch from 8d03308 to 3e3c413 Compare September 6, 2024 18:41
@Water-Melon
Copy link
Contributor Author

@Water-Melon Water-Melon force-pushed the skip_ada_in_aws_linux_2 branch from 3e3c413 to 88b9995 Compare September 6, 2024 18:58
@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 6, 2024
@Water-Melon Water-Melon marked this pull request as ready for review September 6, 2024 18:58
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to solve the ADA problem, and SIMD problem somehow. Disabling them is not a good solution as then our distributions start to behave differently or we cannot implement certain types of functionality.

Options:

  1. try to get ada and simdjson into amazonlinux-2, OR
  2. remove amazonlinux-2

For example this cannot be merged if we remove ada from amazonlinux-2:
#13619

@Water-Melon Water-Melon closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants